Fix: don't modify operator precedence in operator-assignment autofixer #8358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the operator-assignment autofixer could sometimes modify semantics or produce a syntax error due to different operator precedence. This commit updates the fixer to surround the right side of an assignment with parentheses if it has lower precedence than its new neighbor.
not-an-aardvark
added
accepted
|
LGTM |
platinumazure
approved these changes
Mar 29, 2017
ilyavolodin
suggested changes
Mar 29, 2017
| options: ["never"], | ||
| errors: UNEXPECTED_OPERATOR_ASSIGNMENT | ||
| }, { | ||
| code: "foo *= (bar + 1)", |
There was a problem hiding this comment.
Can you add some tests for fixes that don't modify precedence? Like foo += bar + 1
There was a problem hiding this comment.
I added a similar test for foo -= bar - baz, but I can add one for + as well.
Note that addition isn't associative in JS, so the parentheses on the right would still be necessary:
foo = 1;
bar = 2;
baz = '3';foo += bar + baz // => foo is "123"foo = foo + (bar + baz) // => foo is "123"foo = foo + bar + baz // => foo is "33"
|
LGTM |
ilyavolodin
approved these changes
Mar 29, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
I expected the code to be autofixed to
What actually happened? Please include the actual, raw output from ESLint.
The code was autofixed to
What changes did you make? (Give an overview)
Previously, the operator-assignment autofixer could sometimes modify semantics or produce a syntax error due to different operator precedence. This commit updates the fixer to surround the right side of an assignment with parentheses if it has lower precedence than its new neighbor.
Is there anything you'd like reviewers to focus on?
Nothing in particular