Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dot-notation autofix produces syntax errors for object called "let" #8807

Merged
merged 1 commit into from Jun 27, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

  • ESLint Version: master
  • Node Version: 8.1.2
  • npm Version: 5.0.3

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

rules:
  dot-notation: [error, { allowKeywords: false }]

What did you do? Please include the actual source code causing the issue.

var let = { if() { console.log('foo') } };
let.if();

What did you expect to happen?

I expected eslint --fix to not break the code.

What actually happened? Please include the actual, raw output from ESLint.

The code was autofixed to invalid syntax:

var let = { if() { console.log('foo') } };
let["if"]();

What changes did you make? (Give an overview)

The dot-notation autofixer previously fixed code like let.if to let["if"]. However, this is a syntax error because a statement beginning with let[ is parsed as the start of a variable declaration, not a MemberExpression.

Is there anything you'd like reviewers to focus on?

Nothing in particular

The `dot-notation` autofixer previously fixed code like `let.if` to `let["if"]`. However, this is a syntax error because a statement beginning with `let[` is parsed as the start of a variable declaration, not a MemberExpression.
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Jun 26, 2017
@eslintbot
Copy link

LGTM

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this apply to const as well?

@not-an-aardvark
Copy link
Member Author

No, because unlike let, const is not a valid variable name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants