Update: no-restricted-globals custom error messages (fixes #8315) #8932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
platinumazure
added
accepted
|
It looks like there's a discussion to expand this option to other rules as well: #8400 I think it's totally fine to do this rule in its own PR, just wanted to raise awareness so we can make the APIs match. |
|
@kaicataldo Just let me know if you think I should "ref" the combined issue rather than "fixing" the issue I currently have listed in the commit message! 😄 |
|
LGTM |
ilyavolodin
approved these changes
Jul 16, 2017
not-an-aardvark
deleted the
issue8315-no-restricted-globals-custom-messages
branch
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #8315.
What changes did you make? (Give an overview)
Updated schema for
no-restricted-globalsto support custom error messages, similar tono-restricted-syntax.Is there anything you'd like reviewers to focus on?
Nothing in particular.