Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix badge in eslint-config-eslint readme #8954

Merged
merged 1 commit into from Jul 17, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

The badge in the eslint-config-eslint readme correctly links to the eslint-config-eslint package, but it displays the image for eslint. As a result, the displayed version number is incorrect (it displays the version of the latest eslint release, not the latest eslint-config-eslint release).

Is there anything you'd like reviewers to focus on?

No

The badge in the `eslint-config-eslint` readme correctly links to the `eslint-config-eslint` package, but it displays the image for `eslint`. As a result, the displayed version number is incorrect (it displays the version of the latest `eslint` release, not the latest `eslint-config-eslint` release).
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas to be a potential reviewer.

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Jul 17, 2017
@eslintbot
Copy link

LGTM

@ilyavolodin ilyavolodin merged commit 601039d into master Jul 17, 2017
@ilyavolodin ilyavolodin deleted the fix-config-npm-badge branch July 17, 2017 14:32
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants