Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix misleading comment in RuleTester #8995

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This fixes a misleading comment in the RuleTester source file. The RuleTester API exposes a run method, not an add method.

Is there anything you'd like reviewers to focus on?

No

The `RuleTester` API exposes a `run` method, not an `add` method.
@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Jul 24, 2017
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @nzakas and @gyandeeps to be potential reviewers.

@not-an-aardvark not-an-aardvark merged commit c3ee46b into master Jul 24, 2017
@not-an-aardvark not-an-aardvark deleted the rule-tester-misleading-comment branch July 24, 2017 05:07
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants