Fix: Add error mssg in bin/eslint (fixes #9011) #9041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VictorHom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @nzakas and @platinumazure to be potential reviewers. |
|
LGTM |
not-an-aardvark
suggested changes
Jul 30, 2017
tests/bin/eslint.js
Outdated
| @@ -271,9 +271,6 @@ describe("bin/eslint.js", () => { | |||
|
|
|||
| assert.strictEqual(output.stdout, ""); | |||
| assert.include(output.stderr, expectedSubstring); | |||
|
|
|||
| // The message should appear exactly once in stderr | |||
| assert.strictEqual(output.stderr.indexOf(expectedSubstring), output.stderr.lastIndexOf(expectedSubstring)); | |||
| }); | |||
|
|
|||
| return Promise.all([exitCodeAssertion, outputAssertion]); | |||
There was a problem hiding this comment.
Can you add a regression test for #9011?
not-an-aardvark
added
accepted
|
LGTM |
|
LGTM |
not-an-aardvark
approved these changes
Jul 31, 2017
gyandeeps
approved these changes
Jul 31, 2017
|
Thanks for contributing! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ X] Bug fix (template)
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
eslint: v4.3.0
node: v8.2.1
npm: 3.10.10
What changes did you make? (Give an overview)
Add back err.message to bin/eslint
It provides clearer error messaging. It undoes changes here to reduce duplicate error messaging in err.message and err.stack
Is there anything you'd like reviewers to focus on?