Chore: enable object-curly-newline & object-property-newline.(fixes #9042)

[aladdin-add]

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)
enalbe object-curly-newline.(fixes #9042)

Is there anything you'd like reviewers to focus on?

Personally I see the fixed code looks a little strange:

context.report({
  node, message, data: {
    name: node.name
  }
});

any thoughts?

[eslintbot]

LGTM

[not-an-aardvark]

Personally I see the fixed code looks a little strange:

context.report({
 node, message, data: {
   name: node.name
 }
});

any thoughts?

Personally, I prefer putting everything on a new line in that case:

context.report({
  node,
  message,
  data: { name: node.name }
});

[aladdin-add]

agree. is there a rule or option to enforce this? I thought consistent: true would fix it to something like you mentioned. @not-an-aardvark

[not-an-aardvark]

I think object-property-newline enforces that.

[aladdin-add]

what if I want to allow (all in one line):

var foo = { key1: 1, key2: 2, key3: 3 };

and per property per line:

var foo = {
  key1: 1,
  key2: 2,
  key3: 3,
};

just report inconsistent properties like this:

var foo = {
  key1: 1, key2: 2,
  key3: 3
};

this is exactly we are using.

[eslintbot]

LGTM

[eslintbot]

LGTM

[eslintbot]

LGTM

[not-an-aardvark]

Does the allowMultiplePropertiesPerLine option solve that?

[aladdin-add]

no, it only allow multi-properties per line. and will not report error when being inconsistent. I think this can be an useful enhancement for many users.

oh, sorry, it does. I just missed something.

updated the commits. also enable object-property-newline. and it looks better.

@not-an-aardvark ,thanks for your patience! ❤️

[eslintbot]

Thanks for the pull request, @aladdin-add! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[eslintbot]

LGTM

[eslintbot]

LGTM

[not-an-aardvark]

oh, sorry, it does. I just missed something.

Yeah, the option name is a bit misleading :P

[not-an-aardvark]

Looks good to me. Thanks!