Update: indent flatTernary option to handle return
(fixes #9285)
#9296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (#9285)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This updates the
flatTernaryExpression
option ofindent
to check whether a ternary expression is on the same line as a statement, rather than checking if the expression itself starts the statement.As a sidenote, it seems like it might be possible to create a reasonable checker for
BinaryExpression
andLogicalExpression
nodes using this same heuristic.Is there anything you'd like reviewers to focus on?
Does the updated behavior make sense? Are there cases where it doesn't work well?