Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: recognise multiline comments as multiline arrays (fixes #9211) #9369

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

philquinn
Copy link
Contributor

Fixes #9211

What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix

What changes did you make? (Give an overview)

Added another case for requiring line breaks. This is when an array contains only a comment and spans multiple lines. Before it failed on this as it did not recognise the new lines as it was empty according to the check.

Is there anything you'd like reviewers to focus on?

No

@eslintbot
Copy link

LGTM

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Sep 29, 2017
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit 8da525f into eslint:master Oct 6, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 5, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

array-bracket-newline doesn't count multiline comment as multiline
4 participants