Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure no-await-in-loop reports the correct node (fixes #9992) #9993

Merged
merged 1 commit into from Feb 20, 2018

Conversation

@not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Feb 20, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (#9992)

What changes did you make? (Give an overview)

This fixes a regression in f012b8c where no-await-in-loop started reporting the surrounding loop node rather than the AwaitExpression node. As a result, some eslint-disable comments broke and caused more errors because they were on the wrong line.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@kaicataldo kaicataldo merged commit f417506 into master Feb 20, 2018
5 checks passed
@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Feb 20, 2018

LGTM. Thanks for contributing!

@ilyavolodin ilyavolodin deleted the no-await-in-loop-report-location branch Feb 20, 2018
taneliang added a commit to nusmodifications/nusmods that referenced this issue Feb 25, 2018
Revert
f424811
as upstream bug was fixed (see
eslint/eslint#9993)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants