Skip to content

Commit

Permalink
upgrade dev dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
@mdjermanovic
mdjermanovic committed Feb 10, 2021
1 parent bc4ed22 commit b5f0ed4
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 62 deletions.
6 changes: 3 additions & 3 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"homepage": "https://github.com/eslint/eslintrc#readme",
"devDependencies": {
"chai": "^4.2.0",
"eslint": "^7.13.0",
"eslint-config-eslint": "^6.0.0",
"eslint-plugin-jsdoc": "^22.1.0",
"eslint": "^7.19.0",
"eslint-config-eslint": "^7.0.0",
"eslint-plugin-jsdoc": "^31.6.1",
"eslint-plugin-node": "^11.1.0",
"eslint-release": "^3.1.2",
"fs-teardown": "^0.1.0",
Expand Down
47 changes: 24 additions & 23 deletions tests/lib/cascading-config-array-factory.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe("CascadingConfigArrayFactory", () => {

let prepare, cleanup, getPath;

before(async() => {
before(async () => {
({ prepare, cleanup, getPath } = createCustomTeardown({
cwd: root,
files
Expand Down Expand Up @@ -166,7 +166,7 @@ describe("CascadingConfigArrayFactory", () => {

let prepare, cleanup, getPath;

beforeEach(async() => {
beforeEach(async () => {

({ prepare, cleanup, getPath } = createCustomTeardown({
cwd: homeDir,
Expand Down Expand Up @@ -194,7 +194,7 @@ describe("CascadingConfigArrayFactory", () => {

// no warning.
describe("when it lints 'subdir/exist-with-root/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("exist-with-root/test.js");
await delay();
});
Expand All @@ -213,7 +213,7 @@ describe("CascadingConfigArrayFactory", () => {

// no warning.
describe("when it lints 'subdir/exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("exist/test.js");
await delay();
});
Expand All @@ -232,7 +232,7 @@ describe("CascadingConfigArrayFactory", () => {

// no warning
describe("when it lints 'subdir/not-exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("not-exist/test.js");
await delay();
});
Expand All @@ -253,7 +253,7 @@ describe("CascadingConfigArrayFactory", () => {
describe("when '~/.eslintrc.json' exists and CWD is `~/subdir`", () => {
let prepare, cleanup, getPath;

beforeEach(async() => {
beforeEach(async () => {
cwd = path.resolve(homeDir, "subdir");

({ prepare, cleanup, getPath } = createCustomTeardown({
Expand All @@ -278,14 +278,14 @@ describe("CascadingConfigArrayFactory", () => {
factory = new CascadingConfigArrayFactory({ cwd });
});

afterEach(async() => {
afterEach(async () => {
await cleanup();
sh.rm("-rf", homeDir);
});

// Project's config file has `root:true`, then no warning.
describe("when it lints 'subdir/exist-with-root/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("exist-with-root/test.js");
await delay();
});
Expand All @@ -304,7 +304,7 @@ describe("CascadingConfigArrayFactory", () => {

// Project's config file doesn't have `root:true` and home is ancestor, then ESLINT_PERSONAL_CONFIG_SUPPRESS.
describe("when it lints 'subdir/exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("exist/test.js");
await delay();
});
Expand All @@ -331,7 +331,7 @@ describe("CascadingConfigArrayFactory", () => {
* In this case, ESLint will continue to use `~/.eslintrc.json` even if personal config file feature is removed.
*/
describe("when it lints 'subdir/not-exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("not-exist/test.js");
await delay();
});
Expand All @@ -354,7 +354,7 @@ describe("CascadingConfigArrayFactory", () => {
let prepare, cleanup, getPath;
let configFilePath;

beforeEach(async() => {
beforeEach(async () => {

cwd = path.join(homeDir, "../another");
configFilePath = `../${uniqueHomeDirName}/.eslintrc.json`;
Expand All @@ -380,15 +380,15 @@ describe("CascadingConfigArrayFactory", () => {
factory = new CascadingConfigArrayFactory({ cwd: getPath() });
});

afterEach(async() => {
afterEach(async () => {
await cleanup();
sh.rm("-rf", homeDir);
});


// Project's config file has `root:true`, then no warning.
describe("when it lints 'exist-with-root/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("exist-with-root/test.js");
await delay();
});
Expand All @@ -407,7 +407,7 @@ describe("CascadingConfigArrayFactory", () => {

// Project's config file doesn't have `root:true` but home is not ancestor, then no warning.
describe("when it lints 'exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("exist/test.js");
await delay();
});
Expand All @@ -426,7 +426,7 @@ describe("CascadingConfigArrayFactory", () => {

// Project's config file doesn't exist and home is not ancestor, then ESLINT_PERSONAL_CONFIG_LOAD.
describe("when it lints 'not-exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("not-exist/test.js");
await delay();
});
Expand All @@ -453,7 +453,7 @@ describe("CascadingConfigArrayFactory", () => {

let prepare, cleanup, getPath;

beforeEach(async() => {
beforeEach(async () => {
cwd = path.join(homeDir, "subdir");

({ prepare, cleanup, getPath } = createCustomTeardown({
Expand All @@ -471,13 +471,13 @@ describe("CascadingConfigArrayFactory", () => {
factory = new CascadingConfigArrayFactory({ cwd: getPath() });
});

afterEach(async() => {
afterEach(async () => {
await cleanup();
sh.rm("-rf", homeDir);
});

describe("when it lints 'subdir/exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("exist/test.js");
await delay();
});
Expand All @@ -491,7 +491,7 @@ describe("CascadingConfigArrayFactory", () => {
describe("when '~/.eslintrc.json' doesn't exist and CWD is `~/../another`", () => {
let prepare, cleanup, getPath;

beforeEach(async() => {
beforeEach(async () => {
cwd = path.join(homeDir, "../another");

({ prepare, cleanup, getPath } = createCustomTeardown({
Expand All @@ -512,7 +512,7 @@ describe("CascadingConfigArrayFactory", () => {
afterEach(() => cleanup());

describe("when it lints 'not-exist/test.js'", () => {
beforeEach(async() => {
beforeEach(async () => {
config = factory.getConfigArrayForFile("not-exist/test.js", { ignoreNotFoundError: true });
await delay();
});
Expand Down Expand Up @@ -1820,7 +1820,7 @@ describe("CascadingConfigArrayFactory", () => {
process.removeListener("warning", onWarning);
});

it("should emit a deprecation warning if 'ecmaFeatures' is given.", async() => {
it("should emit a deprecation warning if 'ecmaFeatures' is given.", async () => {
getConfig(factory, "ecma-features/test.js");

// Wait for "warning" event.
Expand Down Expand Up @@ -1850,7 +1850,7 @@ describe("CascadingConfigArrayFactory", () => {
/** @type {CascadingConfigArrayFactory} */
let factory;

beforeEach(async() => {
beforeEach(async () => {
await prepare();
additionalPluginPool = new Map();
factory = new CascadingConfigArrayFactory({
Expand Down Expand Up @@ -1909,6 +1909,7 @@ describe("CascadingConfigArrayFactory", () => {
});

describe("bug fixes", () => {

/*
* Clearing cache would previously error on 'createBaseConfigArray()' call
* with 'TypeError: loadRules is not a function'
Expand All @@ -1919,7 +1920,7 @@ describe("CascadingConfigArrayFactory", () => {
rulePaths: ["./rules"],
loadRules() {
return [];
},
}
});

factory.clearCache();
Expand Down
Loading

0 comments on commit b5f0ed4

Please sign in to comment.