Update: Allow eslint:all and eslint:recommended paths to be passed in #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code LGTM.
Small suggestion: might be nice to update typedefs for CascadingConfigArrayFactoryOptions, CascadingConfigArrayFactoryInternalSlots, ConfigArrayFactoryOptions, and ConfigArrayFactoryInternalSlots.
Question: what's the plan for tests in this repository? (we are currently running tests from tests/lib/shared only; other tests are more or less broken).
|
I’m going to circle back and do the tests as part of the next step. They need to be overhauled completely to work in this repo, so I figure I’ll bundle that work with removing the corresponding test files from the eslint repo. Totally missed the typedefs. I’ll update those. |
|
Updated type info. |
yeonjuan
reviewed
Oct 15, 2020
Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to pass in the location of
eslint:allandeslint:recommendedconfigs from the maineslintproject.This is necessary for proper calculation of configs at runtime while allowing
eslintto be the source of truth for that information.