fix: Plugins should always use the same reference #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a plugin the first time, we should create a normalized plugin object and then cache it to use later so every reference to the same plugin is represented by the same normalized plugin reference. Refs eslint/eslint#16277 Closes #89 Closes #90
This was referenced Sep 8, 2022
btmills
approved these changes
Sep 12, 2022
btmills
added a commit
to eslint/eslint
that referenced
this pull request
Sep 12, 2022
`@eslint/eslintrc@1.3.2` [1] contains eslint/eslintrc#91, which together with this commit will fix #16277. [1]: https://github.com/eslint/eslintrc/releases/tag/v1.3.2
1 task
btmills
added a commit
to eslint/eslint
that referenced
this pull request
Sep 12, 2022
`@eslint/eslintrc@1.3.2` [1] contains eslint/eslintrc#91, which together with this commit will fix #16277. [1]: https://github.com/eslint/eslintrc/releases/tag/v1.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a plugin the first time, we should create a normalized plugin object and then cache it to use later so every reference to the same plugin is represented by the same normalized plugin reference.
Refs eslint/eslint#16277
Closes #89
Closes #90
@aladdin-add @coderaiser