Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cascading-config-array: createBaseConfigArray call: rm useless argument resolver #95

Merged
merged 1 commit into from Sep 27, 2022

Conversation

coderaiser
Copy link
Contributor

Function createBaseConfigArray didn't expect resolver property in arguments.

@eslint-github-bot
Copy link

Hi @coderaiser!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Can you fix the lint error (trailing comma on line 253)?

@coderaiser
Copy link
Contributor Author

Sure, just updated

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I've verified that this wasn't related to #53 and eslint/eslint#15036, and that the diff in generated dist/eslintrc.cjs will be just these same lines.

@mdjermanovic mdjermanovic merged commit 56755d9 into eslint:main Sep 27, 2022
@coderaiser coderaiser deleted the patch-1 branch September 27, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants