Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update FlatCompat docs + typings to reflect Array #99

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

wesbos
Copy link
Contributor

@wesbos wesbos commented Dec 23, 2022

I know this repo is frozen, but I'm just trying out 1.4 and all the compat methods give me an array, passing them into the export default [] as shown in the docs gives "Unexpected Array" Error.

Perhaps there is just a missing .flat() on the end of the config instead of having to spread into the config array?

@eslint-github-bot
Copy link

Hi @wesbos!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 23, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@wesbos wesbos changed the title Update FlatCompat docs + typings to reflect Array fix: Update FlatCompat docs + typings to reflect Array Dec 23, 2022
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Dec 23, 2022
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you. This was on my list to get back to fixing.

@nzakas nzakas merged commit 5be711e into eslint:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants