Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpressionStatement#directive property #358

Closed
mysticatea opened this issue Oct 27, 2017 · 0 comments · Fixed by #360
Closed

ExpressionStatement#directive property #358

mysticatea opened this issue Oct 27, 2017 · 0 comments · Fixed by #360
Assignees
@mysticatea
Labels
accepted enhancement

Comments

@mysticatea
Copy link
Member

Before, ESTree spec added ExpressionStatement#directive property for directive prologues: estree/estree@b3de58c...1da8e60

We should follow the spec change.

I worked on acorn: acornjs/acorn#593
I will update acorn after it's released.
@mysticatea mysticatea self-assigned this Oct 27, 2017
@mysticatea mysticatea mentioned this issue Oct 30, 2017
Merged
aladdin-add pushed a commit that referenced this issue Oct 31, 2017
@mysticatea @aladdin-add
Chore: upgrade acorn@5.2 (fixes #358) (#360)
59c9d06 
* Chore: upgrade acorn

* Chore: fix tests for directives

* Fix: library tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mysticatea mysticatea

Labels
accepted enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: upgrade acorn@5.2 (fixes #358) eslint/espree
1 participant
@mysticatea