Fix: "await" is a future reserved word (fixes #151) #152
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "lineNumber": 1, | ||
| "column": 12, | ||
| "description": "Use of future reserved word in strict mode" | ||
| }; |
There was a problem hiding this comment.
Missing linebreak at the end.
| @@ -113,7 +113,7 @@ module.exports = { | |||
| } | |||
| }, | |||
|
|
|||
| isStrictModeReservedWord: function(id) { | |||
| isStrictModeReservedWord: function(id, ecmaFeatures) { | |||
There was a problem hiding this comment.
Why pass in the whole object when only one flag is necessary?
There was a problem hiding this comment.
You're right of course. I did it mostly for consistency with isKeyword and to avoid the boolean parameter code smell.
|
@jrvidal can you add a line break at the end of those files? |
|
I think it's already done! The diff comments are still visible because adding the |
|
Got it. LGTM. |
nzakas
added a commit
that referenced
this pull request
Jun 26, 2015
Fix: "await" is a future reserved word (fixes #151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.