Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: } token followed by template had been lost (fixes #293) #294

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Sep 19, 2016

Fixes #293.

Espree does not handle the previous } token at the first back quote of a template literal. As a result, the template literal is made from [ </code>, }, template, <code> ] sequence. The 2nd item } is the lost } token.

This PR makes espree handling the previous } token at the first back quote of a template literal.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilyavolodin ilyavolodin merged commit 80abdce into master Sep 26, 2016
@mysticatea mysticatea deleted the issue293 branch September 26, 2016 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants