Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: reset isAsync flag for each property (fixes #298) #299

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Fix: reset isAsync flag for each property (fixes #298) #299

merged 1 commit into from
Sep 29, 2016

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Sep 29, 2016 •
edited

Fixes #298.

({ async foo: 1 }) is syntax error, so parsePropertyValue method throws syntax error at : if isAsync flag is true.
Then, isAsync was true at the 2nd property since isAsync flag had not been reset for each property.

This PR adds else { isAsync = false; } to reset isAsync flag.

This code corresponds to expression.js#L530-L532 in Acorn.

nzakas
nzakas approved these changes Sep 29, 2016
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 7d3e2fc into master Sep 29, 2016
@mysticatea mysticatea deleted the issue298 branch September 29, 2016 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
CLA: Valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mysticatea @nzakas @jquerybot