Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Lock acorn to v4.0.4 #314

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Build: Lock acorn to v4.0.4 #314

merged 1 commit into from
Feb 2, 2017

Conversation

@kaicataldo kaicataldo merged commit f55fa51 into master Feb 2, 2017
@kaicataldo kaicataldo deleted the lock-acorn branch February 2, 2017 23:00
@puzrin
Copy link

puzrin commented Feb 3, 2017

Note, 4.0.7 not hangs, but still only partially fixed another bug acornjs/acorn#500 (comment). After forced updates i still see error report in eslint. It worth keep espree on 4.0.4 a bit more.

@puzrin
Copy link

puzrin commented Feb 3, 2017

Update: 4.0.8 fixed things (see link above for details).

As author says, technically that fix is not perfect and should be improved. But 4.0.4 had the same problem. So now 4.0.8 should be not worse than 4.0.4.

@gyandeeps
Copy link
Member

Apparently 4.0.8 has some other issues: #316

@puzrin
Copy link

puzrin commented Feb 3, 2017

Sorry for confusion, i meaned only very specific case like [ (G = s), F = G ], which could be missed in tests.

@nzakas
Copy link
Member

nzakas commented Feb 5, 2017

Just a reminder: dependency changes should be "Upgrade:" or "Update" (in this case). This change is unrelated to the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants