Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: acorn to ^4.0.11 #317

Merged
merged 4 commits into from
Mar 18, 2017
Merged

Upgrade: acorn to ^4.0.11 #317

merged 4 commits into from
Mar 18, 2017

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Feb 7, 2017 •
edited
Loading

This PR upgrades Acorn to latest.
It needs to fix some tests.

  • It improved the error message of parenthesized assignment targets.
  • I fixed the syntax error in 6/destructuring/named-param.
  • It gets correct AST nodes about ExportDeclarations with expressions. (it gets to not make wrong EmptyStatement node.) EDIT: this is a bug.
  • It changed the location of "Illegal 'use strict' directive in function with non-simple parameter list" message.

4 errors about below remain:

@gyandeeps gyandeeps mentioned this pull request Feb 7, 2017
Closed
@mysticatea
Copy link
Member Author

I guess acornjs/acorn#507 is the last issue to upgrade acorn.

@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg mentioned this pull request Feb 8, 2017
Closed
11 tasks
@mysticatea
Copy link
Member Author

Memo: this should fix eslint/eslint#6542.

@mysticatea mysticatea changed the title [WIP] Upgrade: acorn to latest Upgrade: acorn to ^4.0.11 Feb 8, 2017
@mysticatea
Copy link
Member Author

I'm sure this is ready to merge.
I confirmed tests of espree and eslint are passed.

btmills
btmills approved these changes Feb 8, 2017
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not-an-aardvark
not-an-aardvark approved these changes Feb 8, 2017
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eslint-canary also runs successfully with this change.

@not-an-aardvark
Copy link
Member

Is this ready to merge?

@not-an-aardvark not-an-aardvark merged commit 9d86ba5 into master Mar 18, 2017
@ilyavolodin ilyavolodin deleted the upgrade-acorn branch March 18, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btmills btmills btmills approved these changes

@gyandeeps gyandeeps gyandeeps approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mysticatea @not-an-aardvark @btmills @gyandeeps