Fix: raise error for trailing commas after rest properties (fixes #310) #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this change is due to a spec update, it should be breaking. If this was just a long-existing bug we didn't notice, then it's just a patch. |
|
The spec has been consistent on this -- it's just a long-existing bug. |
ilyavolodin
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the rest property parser to raise an error if it encounters a trailing comma. The lack of an error here has caused a lot of confusion in eslint issues (see #310 for a list of invalid bug reports).
This fixes incorrect behavior, but we should consider whether we want to treat it as a breaking change (see #310).