Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: acorn to 5.1.1 #347

Merged
merged 2 commits into from
Jul 8, 2017
Merged

Upgrade: acorn to 5.1.1 #347

merged 2 commits into from
Jul 8, 2017

Conversation

not-an-aardvark
Copy link
Member

(fixes #346)

This upgrades acorn to 5.1.0 and fixes the test suite. It does not add ES2018 support -- I'm planning to make a follow-up PR for that.

The changes in this PR fall into three categories:

  • Some error messages from acorn changed
  • Rest destructuring is only valid when the argument is an identifier in ES2015 (this restriction is lifted in ES2016)
  • Some of our invalid cases should have actually been valid (await is allowed as a method name).

@not-an-aardvark not-an-aardvark changed the title Upgrade: acorn to 5.1.0 Upgrade: acorn to 5.1.1 Jul 6, 2017
@not-an-aardvark not-an-aardvark merged commit 9ac671a into master Jul 8, 2017
@not-an-aardvark not-an-aardvark deleted the acorn-5.1.0 branch July 8, 2017 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to acorn@5.1.0
3 participants