Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove blockBindings from docs (fixes #307, fixes #339) #356

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Fix: Remove blockBindings from docs (fixes #307, fixes #339) #356

merged 2 commits into from
Nov 10, 2017

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Oct 9, 2017

This PR removes the mentioning of the blockBindings option from the Differences from Espree 2.x section in the README as it is no longer supported and the opt-in apparently not necessary anymore.

let and const declarations are no longer parsed by default. You must opt-in using ecmaFeatures.blockBindings.

@platinumazure
Copy link
Member

Hi @Hirse, thanks for the pull request!

I believe one still has to opt in by specifying ecmaVersion: 2015 (or greater). ES5 is still the default, so let and const will not be parsed with the default settings.

@Hirse
Copy link
Contributor Author

Hirse commented Oct 9, 2017

@platinumazure you are right. Based on some testing with the AST explorer there are two ways to enable support for let and const: Using ecmaVersion > 5 or setting sourceType to module. I will update the docs accordingly.

@kaicataldo kaicataldo merged commit 019b70a into eslint:master Nov 10, 2017
@Hirse Hirse deleted the fix/blockBindings branch November 10, 2017 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants