Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: acorn v5.3.0 #365

Merged
merged 1 commit into from Jan 9, 2018
Merged

Upgrade: acorn v5.3.0 #365

merged 1 commit into from Jan 9, 2018

Conversation

mysticatea
Copy link
Member

This PR fixes some test failures that acorn v5.3.0 introduced.

  • It added a new argument to some methods we are overriding: toAssignable and checkPropClash. It didn't seem to trigger crashes but caused to overlook some syntax errors.
  • It improved the error message around async/await.

platinumazure
platinumazure approved these changes Jan 7, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure mentioned this pull request Jan 9, 2018
Merged
@platinumazure
Copy link
Member

@mysticatea Should this be an "Upgrade" commit?

@mysticatea mysticatea changed the title Fix: upgrade acorn Upgrade: acorn v5.3.0 Jan 9, 2018
@mysticatea
Copy link
Member Author

Good point. I agree.

@mysticatea mysticatea merged commit 4160aee into master Jan 9, 2018
@mysticatea mysticatea deleted the fix-test-failures branch January 9, 2018 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@gyandeeps gyandeeps gyandeeps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mysticatea @platinumazure @ilyavolodin @gyandeeps