Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: build failing due to incorrectly super() call (fixes #398) #399

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Fix: build failing due to incorrectly super() call (fixes #398) #399

merged 1 commit into from
Nov 5, 2018

Conversation

aladdin-add
Copy link
Member

No description provided.

@aladdin-add aladdin-add changed the title Fix: build failing due to super() call outside constructor of a subclass (fixes#398) Fix: super() call outside constructor of a subclass (fixes#398) Nov 5, 2018
@aladdin-add aladdin-add changed the title Fix: super() call outside constructor of a subclass (fixes#398) Fix: build failing due to incorrectly super() call (fixes #398) Nov 5, 2018
not-an-aardvark
not-an-aardvark approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 7c278d6 into eslint:master Nov 5, 2018
@aladdin-add aladdin-add deleted the issue398 branch November 6, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted bug build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aladdin-add @not-an-aardvark