Breaking: remove attachComment #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2021
aminya
added a commit
to aminya/espree-attachcomment
that referenced
this pull request
Apr 25, 2021
This was referenced Apr 25, 2021
|
For those who need this, I have registered the latest Espree with this feature: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #394
fixes #378
It looks like running
tools/update-tests.jsbreaks tests right now (with what's currently in master). I just updated the tests for the libs, since they usedattachComment(by commenting out sections of the script before running it). I'd like to see if I can fix those in a follow up PR, but would love to do it separately since this is already a large PR. Thoughts?