Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: added tests for options normalize #439

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

anikethsaha
Copy link
Member

added tests for lib/options.js

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there might be some overlap with some existing tests here and we'll probably want to colocate them so that they're easier to keep track of. That being said, I'm not against adding a test/lib/options.js file and having it be a centralized location for all options tests!

@anikethsaha
Copy link
Member Author

@kaicataldo I agree I think there are 1-2 tests doing similar but in option testing, I am doing unit test for normalize method instead of running the whole parser. yes, it's not to strong as under the hood, its the same.
I would like to know what you suggest !. cause i think too that this options testing is not so important atm as its already being done under the hood.

let me know

@kaicataldo
Copy link
Member

I'm not against unit testing this module, but I do think there's a lot more value in doing a more integration-style test at the parser level.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but otherwise this LGTM. I do think there's value in adding some more integration-style tests at the parser level, but it certainly doesn't hurt to have some unit tests here!

tests/lib/options.js Outdated Show resolved Hide resolved
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 9a4cff3 into eslint:master Apr 24, 2020
@kaicataldo
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants