Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support optional chaining #446

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Update: support optional chaining #446

merged 2 commits into from
Jun 23, 2020

Conversation

mysticatea
Copy link
Member

This PR adds support for optional chaining.

  • Upgrade acorn
  • Upgrade eslint-visitor-keys
  • Modify token translation logic for the new punctuator token ?..

package.json Outdated Show resolved Hide resolved
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 872645c into master Jun 23, 2020
@mysticatea mysticatea deleted the optional-chaining branch June 25, 2020 22:40
@mysticatea mysticatea restored the optional-chaining branch June 25, 2020 22:40
@SilencerWeb
Copy link

Hi! Is there any way to know at least an estimated date when a new version with this will be released so ESLint would be able to parse optional chaining? 🙂

@aladdin-add
Copy link
Member

we do a release in every 2 weeks, so it will be in the next release(7.4.0). please follow the release issue: eslint/eslint#13443

@SilencerWeb
Copy link

@aladdin-add, thanks a lot!

@kaicataldo kaicataldo deleted the optional-chaining branch July 18, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants