New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Support top-level await and regexp match indices #505
Conversation
tests/fixtures/ecma-version/13/regexp-match-indices/regexp-match-indices.result.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supported features in readme needs to be updated, too.
https://github.com/eslint/espree#what-ecmascript-features-do-you-support
Okay, should be all set now. |
tests/fixtures/ecma-version/13/top-level-await/top-await.result.js
Outdated
Show resolved
Hide resolved
tests/fixtures/ecma-version/13/regexp-match-indices/regexp-match-indices.result.js
Outdated
Show resolved
Hide resolved
tests/fixtures/ecma-version/13/regexp-match-indices/regexp-match-indices.result.js
Outdated
Show resolved
Hide resolved
…ch-indices.result.js Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
…ch-indices.result.js Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
I think we need the top-level await tests to have espree/tests/lib/ecma-version.js Line 38 in c8ca49a
(that "Only" in the variable name is misleading) I can see this test in the output, it's passing only because the current Acorn allows that:
We can make a |
I updated the tests. I’d like to see if there’s a new Acorn release in the next couple days with the top-level await fix. |
A new release of Acorn was published, so added that. |
Updates Acorn and adds tests for top-level await and regexp match indices.
Refs eslint/eslint#14632
Refs eslint/eslint#14640