-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Allow escaping characters on Windows #61
Conversation
It seems that one test in eslint/eslint fails after this change. I'll look into this more. |
The problem is with |
Now that eslint/eslint#18613 has been merged, this is ready for review. I just tagged this as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
And yes, I do believe this should be marked as breaking for this package.
Leaving open for others to review over the weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Prerequisites checklist
What is the purpose of this pull request?
Allows using
\
as an escape character in patterns regardless of the operating system. In particular, on Windows.What changes did you make? (Give an overview)
Enabled
allowWindowsEscape
minimatch option.Related Issues
refs eslint/eslint#18597
Is there anything you'd like reviewers to focus on?
Should this maybe be marked as a breaking change for this package?