You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the release-please workflow, like in other our repos, some steps should be run only when we merge a release PR (i.e. when we want to publish a new version of the package):
To clarify, my concern is less about running unnecessary installation steps, it's more than it might continue to the publish steps in case that the merged PR was changing files inside the packages.
Which packages are affected?
@eslint/object-schema
Environment
This is a CI/CD issue.
What did you do?
Yesterday, I merged #6 and wanted to check the release-please workflow run.
Here's the run that was triggered by that merge:
https://github.com/eslint/rewrite/actions/runs/8967052291
In the release-please workflow, like in other our repos, some steps should be run only when we merge a release PR (i.e. when we want to publish a new version of the package):
rewrite/.github/workflows/release-please.yml
Lines 22 to 104 in e125712
What did you expect to happen?
Since this was a "normal" (non-release) PR, I expected the above steps not to run.
What actually happened?
The run printed "A release was created." and proceeded to checkout the repo, install Node.js, and package dependencies.
It didn't proceed with further steps that would publish the packages, but it could be just because the PR wasn't changing any files in them.
Link to Minimal Reproducible Example
N/A
Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: