Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: treat * as a universal pattern #50

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix!: treat * as a universal pattern #50

merged 2 commits into from
Jun 11, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Fixes the bug reported in eslint/eslint#18550.

What changes did you make? (Give an overview)

Changed getConfigWithStatus to treat lone * as a universal pattern.

This means that files matching only * will be "unconfigured".

Related Issues

eslint/eslint#18550

Is there anything you'd like reviewers to focus on?

I tagged this as fix! because I think this should be treated as a breaking change for the config-array package.

@eslint-github-bot eslint-github-bot bot added breaking bug Something isn't working labels Jun 7, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can you also add a note in the README?

@mdjermanovic
Copy link
Member Author

Rebased to fix merge conflicts, and updated the README.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @fasttime to approve before merging.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 79ad4bc into main Jun 11, 2024
14 checks passed
@fasttime fasttime deleted the eslint-issue18550 branch June 11, 2024 10:29
@github-actions github-actions bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted breaking bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants