Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add 2023-11-30 meeting notes #472

Merged
merged 3 commits into from
Dec 7, 2023
Merged

docs: Add 2023-11-30 meeting notes #472

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45eed2e
docs: Add 2023-11-30 meeting notes
sam3k Dec 1, 2023
5fce50b
docs: correcting 2023-11-30 meeting notes
sam3k Dec 6, 2023
d1d0a44
Update notes/2023/2023-11-30.md
nzakas Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 42 additions & 0 deletions notes/2023/2023-11-30.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# 2023-11-30 ESLint TSC Meeting Notes

## Transcript

[`2023-11-30-transcript.md`](2023-11-30-transcript.md)

## Attending

* Nicholas C. Zakas (@nzakas) - TSC
* Milos Djermanovic (@mdjermanovic) - TSC

@nzakas moderated, and @sam3k took notes.

## Topics

### [v9.0.0 Status](https://github.com/orgs/eslint/projects/4/views/2)

| Feature | Status | Notes |
| ------- | -- | -- |
| [Change Request: Drop Node v12/v14/v16/v17/v19 support](https://github.com/eslint/eslint/issues/17595) | PR is ready for merge | @nzakas and @mdjermanovic will set status to ready for merge |
| [Change Request: Remove all formatters except stylish, html, json, and json-with-meta](https://github.com/eslint/eslint/issues/17524) | Waiting on the last remaining changes from @mdjermanovic | |
| [Change default rule schema to `schema: []` and drop support for function-style rules](https://github.com/eslint/eslint/issues/14709) | @mdjermanovic opened [draft PR](https://github.com/eslint/eslint/pull/17792) | |
| [Change Request: stop running rules set to "warn" when `--quiet` is used](https://github.com/eslint/eslint/issues/16450) | Close to done; just making final changes. | |
| [Omiting any file/dir positional parameter to CLI does not give an error](https://github.com/eslint/eslint/issues/14308) | Ready for review | @mdjermanovic will review soon |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review or ready to implement? Issue status says "ready to implement" and the PR linked to this issue is in draft.

Let me know and I'll update the status of the issue if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status should be "Implementing" 👍 Thanks for catching that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected and updated the status on the issue itself.

| [Implement Language Plugins](https://github.com/eslint/eslint/issues/16999) | Once [#17698](https://github.com/eslint/eslint/pull/17698) and [#143](https://github.com/eslint-community/eslint-plugin-n/issues/143) are merged, we can move this one to ready to merge | |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look correct to you? I was a bit lost on this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait to leave an update on the issue till this is more clear.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite there. eslint/eslint#17698 is ready for review, but we can't merge until eslint-community/eslint-plugin-n#143 is complete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

| [Implement Flat Config](https://github.com/eslint/eslint/issues/13481) | **Blocked** | Blocked by work left on getting the rule tests switched over to use `FlatRuleTester`. Once that's merged, @nzakas will start on the docs. Also, we won't rename files in this PR. It will be handle separately. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are disabled for this issue so won't be able to leave an update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird...as a team member I thought you should be able to do leave a comment still. I'll look into this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see:
Screenshot 2023-12-05 at 7 52 32 PM

Btw, it is the same case with Discord's tsc-meeting channel. I cannot comment or react to a comment. I can only react to someone's else reactions. In case it seems I'm very quiet when I do attend. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord is intentionally set up that way. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so you have "triage" permissions on the repo and apparently that wasn't enough. I've bumped that up to "write" permissions. Can you see if that works?

| [Change Request: Remove deprecated context pass-through SourceCode methods](https://github.com/eslint/eslint/issues/17520) | This one will be ready along with the language plugins issue because it's all in the same PR | |
| [Change Request: Enable `reportUnusedDisableDirectives` config option by default](https://github.com/eslint/eslint/issues/15466) | Waiting on @bmish to finish up the [PR (draft)](https://github.com/eslint/eslint/pull/17212) | |

### [Contributor Pool for November](https://github.com/issues?q=org%3Aeslint+label%3A%22contributor+pool%22+merged%3A2023-11-01..2023-11-30)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you've told me to begin adding the contributor pool to this file? If not, let me know and I'll remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!


* `$100` @That_Guy997 for [feat: for-direction rule add check for condition in reverse order](https://github.com/eslint/eslint/pull/17755)
nzakas marked this conversation as resolved.
Show resolved Hide resolved
* `$300` @That_Guy997 for Contributions to [help](https://discord.com/channels/688543509199716507/1059928426217209896)

### Scheduled release for December 1st, 2023

**Action Items:** @mdjermanovic will release the following:
* `eslint`
* `@eslint/js`
* `@eslint/eslintrc`