Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links on the site #668

Open
ilyavolodin opened this issue Dec 11, 2019 · 5 comments
Open

Fix broken links on the site #668

ilyavolodin opened this issue Dec 11, 2019 · 5 comments
Labels
bug

Comments

@ilyavolodin
Copy link
Member

@ilyavolodin ilyavolodin commented Dec 11, 2019

I ran a local crawler on the site and here's the list of links that were broken:

http://localhost:8080/docs/maintainer-guide/governance links to missing page. List of links is ["http://localhost:8080/docs/maintainer-guide/contributing"]
Error 404 for http://localhost:8080/docs/maintainer-guide/contributing
http://localhost:8080/docs/6.0.0/user-guide/configuring links to missing page. List of links is ["http://localhost:8080/docs/6.0.0/rules/"]
Error 404 for http://localhost:8080/docs/6.0.0/rules/
http://localhost:8080/docs/5.0.0/developer-guide/working-with-rules links to missing page. List of links is ["http://localhost:8080/docs/5.0.0/rules/","http://localhost:8080/docs/5.0.0/rules/"]
Error 404 for http://localhost:8080/docs/5.0.0/rules/
http://localhost:8080/docs/5.0.0/user-guide/configuring links to missing page. List of links is ["http://localhost:8080/docs/5.0.0/rules/"]
http://localhost:8080/docs/4.0.0/user-guide/command-line-interface links to missing page. List of links is ["http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/"]
Error 404 for http://localhost:8080/docs/4.0.0/user-guide/formatters/
http://localhost:8080/blog/2016/02/eslint-v2.0.0-released links to missing page. List of links is ["http://localhost:8080/docs/developer-guide/code-path-analysis.html"]
Error 404 for http://localhost:8080/docs/developer-guide/code-path-analysis.html
http://localhost:8080/docs/2.0.0/developer-guide/working-with-rules links to missing page. List of links is ["http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis"]
http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis links to missing page. List of links is ["http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis/"]
Error 404 for http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis/
http://localhost:8080/blog/2015/06/eslint-0.24.0-released links to missing page. List of links is ["http://localhost:8080/blog/2015/preparing-for-1.0.0"]
Error 404 for http://localhost:8080/blog/2015/preparing-for-1.0.0
Total pages: 939. Errors found 7
@eslint eslint bot added the triage label Dec 11, 2019
@ilyavolodin ilyavolodin added bug and removed triage labels Dec 11, 2019
@dotJoel

This comment has been minimized.

Copy link
Contributor

@dotJoel dotJoel commented Feb 25, 2020

I can look at this today, if you don't mind.
A spot check revealed some destinations are easy to figure out.

dotJoel added a commit to dotJoel/website that referenced this issue Feb 25, 2020
kaicataldo pushed a commit that referenced this issue Feb 25, 2020
@dotJoel

This comment has been minimized.

Copy link
Contributor

@dotJoel dotJoel commented Feb 26, 2020

These three pages don't exist right now.

  • /docs/6.0.0/rules/
  • /docs/5.0.0/rules/
  • /docs/4.0.0/user-guide/formatters/

/3.0.0/rules/ and /4.0.0/rules/ have an index.liquid 5 and 6 do not.
user-guide/formatters/index.md exists in 3.0.0 and 5.0.0, but not in 4.0.0.

I'm not sure what the team would like to do about this.

The remaining two have obvious fixes:

  • http://localhost:8080/docs/2.0.0/developer-guide/working-with-rules links to missing page. List of links is ["http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis"]
    can change to /docs/2.0.0/developer-guide/code-path-analysis.html
  • http://localhost:8080/docs/maintainer-guide/governance links to missing page. List of links is ["http://localhost:8080/docs/maintainer-guide/contributing"]
    can probably change to /docs/developer-guide/contributing
@nzakas

This comment has been minimized.

Copy link
Member

@nzakas nzakas commented Feb 27, 2020

Thanks for digging into that! I think you should be able to check out the version tags on the repo to find the missing files (for example, if you check out the v6.8.0, you should be able to find the missing rules index for v6).

dotJoel added a commit to dotJoel/website that referenced this issue Feb 27, 2020
@qwright10

This comment has been minimized.

@kaicataldo

This comment has been minimized.

Copy link
Member

@kaicataldo kaicataldo commented Mar 27, 2020

@dotJoel Are you still willing to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.