Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Fix broken links on the site #668

Closed
ilyavolodin opened this issue Dec 11, 2019 · 8 comments
Closed

Fix broken links on the site #668

ilyavolodin opened this issue Dec 11, 2019 · 8 comments
Labels
bug The site is working incorrectly

Comments

@ilyavolodin
Copy link
Member

I ran a local crawler on the site and here's the list of links that were broken:

http://localhost:8080/docs/maintainer-guide/governance links to missing page. List of links is ["http://localhost:8080/docs/maintainer-guide/contributing"]
Error 404 for http://localhost:8080/docs/maintainer-guide/contributing
http://localhost:8080/docs/6.0.0/user-guide/configuring links to missing page. List of links is ["http://localhost:8080/docs/6.0.0/rules/"]
Error 404 for http://localhost:8080/docs/6.0.0/rules/
http://localhost:8080/docs/5.0.0/developer-guide/working-with-rules links to missing page. List of links is ["http://localhost:8080/docs/5.0.0/rules/","http://localhost:8080/docs/5.0.0/rules/"]
Error 404 for http://localhost:8080/docs/5.0.0/rules/
http://localhost:8080/docs/5.0.0/user-guide/configuring links to missing page. List of links is ["http://localhost:8080/docs/5.0.0/rules/"]
http://localhost:8080/docs/4.0.0/user-guide/command-line-interface links to missing page. List of links is ["http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/","http://localhost:8080/docs/4.0.0/user-guide/formatters/"]
Error 404 for http://localhost:8080/docs/4.0.0/user-guide/formatters/
http://localhost:8080/blog/2016/02/eslint-v2.0.0-released links to missing page. List of links is ["http://localhost:8080/docs/developer-guide/code-path-analysis.html"]
Error 404 for http://localhost:8080/docs/developer-guide/code-path-analysis.html
http://localhost:8080/docs/2.0.0/developer-guide/working-with-rules links to missing page. List of links is ["http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis"]
http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis links to missing page. List of links is ["http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis/"]
Error 404 for http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis/
http://localhost:8080/blog/2015/06/eslint-0.24.0-released links to missing page. List of links is ["http://localhost:8080/blog/2015/preparing-for-1.0.0"]
Error 404 for http://localhost:8080/blog/2015/preparing-for-1.0.0
Total pages: 939. Errors found 7
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 11, 2019
@ilyavolodin ilyavolodin added bug The site is working incorrectly and removed triage An ESLint team member will look at this issue soon labels Dec 11, 2019
@dotJoel
Copy link
Contributor

dotJoel commented Feb 25, 2020

I can look at this today, if you don't mind.
A spot check revealed some destinations are easy to figure out.

@dotJoel
Copy link
Contributor

dotJoel commented Feb 26, 2020

These three pages don't exist right now.

  • /docs/6.0.0/rules/
  • /docs/5.0.0/rules/
  • /docs/4.0.0/user-guide/formatters/

/3.0.0/rules/ and /4.0.0/rules/ have an index.liquid 5 and 6 do not.
user-guide/formatters/index.md exists in 3.0.0 and 5.0.0, but not in 4.0.0.

I'm not sure what the team would like to do about this.

The remaining two have obvious fixes:

  • http://localhost:8080/docs/2.0.0/developer-guide/working-with-rules links to missing page. List of links is ["http://localhost:8080/docs/2.0.0/developer-guide/code-path-analysis"]
    can change to /docs/2.0.0/developer-guide/code-path-analysis.html
  • http://localhost:8080/docs/maintainer-guide/governance links to missing page. List of links is ["http://localhost:8080/docs/maintainer-guide/contributing"]
    can probably change to /docs/developer-guide/contributing

@nzakas
Copy link
Member

nzakas commented Feb 27, 2020

Thanks for digging into that! I think you should be able to check out the version tags on the repo to find the missing files (for example, if you check out the v6.8.0, you should be able to find the missing rules index for v6).

@qwright10
Copy link

@kaicataldo
Copy link
Member

@dotJoel Are you still willing to work on this?

@dotJoel
Copy link
Contributor

dotJoel commented Mar 30, 2020

@kaicataldo yea.. I will try to finish it up today.
I have some changes ready, but need to address broken links found by running LinkChecker myself. Some seemed related to what I have done so far on this new pending branch.

kaicataldo pushed a commit that referenced this issue Apr 6, 2020
* Fix: Broken links fixed & missing pages added (refs #668)

* Remove debugging typo addition

* fix link as v7 rules are at /docs/rules/

* Add missing rules to 6.0.0
@btmills
Copy link
Member

btmills commented May 29, 2020

@dotJoel thank you for putting together #710! It looks like this is all taken care of and can be closed?, but I wanted to check with you first since you used "refs" rather than "fixes" on that PR to make sure you weren't wanting to leave this open to track any remaining work.

@dotJoel
Copy link
Contributor

dotJoel commented May 29, 2020

@btmills this issue should be resolved by the two PRs. I was not using "refs" the second time to imply that there was work remaining.
I feel this issue is safe to close.

@btmills btmills closed this as completed May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug The site is working incorrectly
Projects
None yet
Development

No branches or pull requests

6 participants