Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polyfill): use stream and events from deno std/node #136

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

talentlessguy
Copy link
Contributor

Similar to #117 but this one adds stream and events modules, potentially fixing a lot of modules, including @web3-react/ packages.

@talentlessguy
Copy link
Contributor Author

there's a problem with web3-react though, not sure whose issue is that but this doesn't get transpiled properly:

import { InjectedConnector } from 'http://localhost:3333/@web3-react/injected-connector'

const injected = new InjectedConnector({})
error: Uncaught TypeError: Class constructor _EventEmitter cannot be invoked without 'new'
    at o.e [as constructor] (http://localhost:3333/v50/@web3-react/abstract-connector@6.0.7/deno/abstract-connector.js:2:328)
    at new o (http://localhost:3333/v50/@web3-react/injected-connector@6.0.7/deno/injected-connector.js:2:2533)
    at file:///tmp/deno.ts:3:18

@ije
Copy link
Member

ije commented Sep 13, 2021

let's use deno.land/std/node url instead of bundling!
so we can upgrade the std version very easily

@ije
Copy link
Member

ije commented Sep 14, 2021

i am going to merge this, then we change to deno.land url instead, lot thanks @talentlessguy

@ije ije merged commit 944a3a0 into master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants