Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which version of phpCAS? #11

Closed
robshep opened this issue Apr 27, 2017 · 4 comments
Closed

which version of phpCAS? #11

robshep opened this issue Apr 27, 2017 · 4 comments

Comments

@robshep
Copy link

robshep commented Apr 27, 2017

The current version of phpCAS doesn't work with this plugin.

The initial breakage happens due to an extra constructor argument for the client.

(boolean 'proxy' is expected as arg no. 2, but in the plugin this argument is for the server host)

The link to the master release of phpCAS is possibly 1.3.5, the latest.
There are security advisories for client lib releases lower than that.

Which release should we select if we want it to work?

Do you think it might be just the constructor? or more fundamental changes?

Thanks

Using the latest plugin which has:

base   authplaincas
author Fabian Bircher
email  fabian@esn.org
date   2016-07-22
name   Plain CAS Auth Plugin
desc   Provides user authentication against a CAS server
url    http://www.dokuwiki.org/plugin:authplaincas
@robshep
Copy link
Author

robshep commented Apr 27, 2017

@robshep
Copy link
Author

robshep commented Apr 27, 2017

Plugin usage of Client constructor:

https://github.com/jasedit/authplaincas/blob/master/auth.php#L174

@phy25
Copy link
Contributor

phy25 commented May 4, 2017

Is this a reproducable issue?

It seems that what auth.php:174 is calling is phpCAS/CAS.php:338, which doesn't have a proxy argument.

@robshep
Copy link
Author

robshep commented May 4, 2017

Sorry, I didn't trace the call properly. The original issue was an error complaining about CAS conf params missing, (something along the lines of "bad port: http:cas.example.com" which I incorrectly traced back to the Client constructor not the factory.

In any case, having applied an SSL certificate the CAS server and changed the authplaincas setting to reflect I can't reproduce the issue. Apologies, I'll close this one.

@robshep robshep closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants