Code Review comments

esnet · Mar 11, 2024 · 0bba334 · 0bba334
1 parent 1516da8
commit 0bba334
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cli/tools/org_preferences.go b/cli/tools/org_preferences.go
@@ -73,7 +73,7 @@ func newUpdateOrgPreferenceCmd() simplecobra.Commander {
 
 			err = rootCmd.GrafanaSvc().UploadOrgPreferences(org, prefere)
 			if err != nil {
-				log.Fatal("Failed to update org preferences")
+				log.Fatalf("Failed to update org preferences, %v", err)
 			}
 			slog.Info("Preferences update for organization", slog.Any("organization", org))
 

diff --git a/internal/service/org_preferences.go b/internal/service/org_preferences.go
@@ -67,7 +67,7 @@ func (s *DashNGoImpl) scopeIntoOrg(orgName string, runTask func() (interface{},
 
 // UploadOrgPreferences Updates the preferences for a given organization.  Returns error if org is not found.
 func (s *DashNGoImpl) UploadOrgPreferences(orgName string, pref *models.Preferences) error {
-	f := func() (interface{}, error) {
+	runTask := func() (interface{}, error) {
 		if pref == nil {
 			return nil, fmt.Errorf("preferences are nil, cannot update")
 		}
@@ -85,10 +85,10 @@ func (s *DashNGoImpl) UploadOrgPreferences(orgName string, pref *models.Preferen
 		}
 		return status, nil
 	}
-	_, err := s.scopeIntoOrg(orgName, f)
+	_, err := s.scopeIntoOrg(orgName, runTask)
 	if err != nil {
 		return err
 	}
-	slog.Info("Organization Preferences were update")
+	slog.Info("Organization Preferences were updated")
 	return nil
 }