Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to .gitignore and error messages #1408

Merged
merged 2 commits into from Nov 15, 2022

Conversation

davidBar-On
Copy link
Contributor

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master

  • Issues fixed (if any):

  • Brief description of code changes (suitable for use as a commit message):

Suggested three minor changes. I am sending all in one PR as I didn't see the point in submitting 3 PRs for such minor changes. In practice, I assume that the accepted/revised changes can be done manually directly the the code (and this PR can be closed).

  1. Add ".vscode/" to .gitignore. Folder is added by Visual Studio Code, at list for me, and I assume this may be the case for others.
  2. Add the return code value of check_authentication() to a debug message, to allow better evaluation of the error.
  3. Enhance IESENDMESSAGE and IERECVMESSAGE messages per this suggestion in issue iperf3: error - unable to send control message: Bad file descriptor #1233 (issue may be closed by the way).

@davidBar-On davidBar-On changed the title minor changes Minor changes to .gitignore and error messages Oct 20, 2022
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm not a huge fan of long error messages, but I understand that inexperienced users might need some more guidance. I'd like it if you could fix a couple of grammatical issues before merging, then we're good.

src/iperf_error.c Outdated Show resolved Hide resolved
src/iperf_error.c Outdated Show resolved Hide resolved
@bmah888 bmah888 merged commit 9d78f79 into esnet:master Nov 15, 2022
@bmah888
Copy link
Contributor

bmah888 commented Nov 15, 2022

Thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants