Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stat reporting interval to JSON .start.test_start #1663

Merged
merged 2 commits into from Mar 22, 2024

Conversation

TheRealDJ
Copy link
Contributor

  • Version of iperf3: master

  • Issues fixed (if any): Added interval to JSON output start.test_start as a floating point number

  • Brief description of code changes (suitable for use as a commit message): Added interval: %f to JSON test_start printf with value test->stats_interval

Example output (master):

# iperf3 --client XXX --omit 0 --time 1 --json | jq .start.test_start
{
  "protocol": "TCP",
  "num_streams": 1,
  "blksize": 131072,
  "omit": 0,
  "duration": 1,
  "bytes": 0,
  "blocks": 0,
  "reverse": 0,
  "tos": 0,
  "target_bitrate": 0,
  "bidir": 0,
  "fqrate": 0
}

Example output (this PR):

# iperf3 --client XXX --omit 0 --time 1 --json | jq .start.test_start
{
  "protocol": "TCP",
  "num_streams": 1,
  "blksize": 131072,
  "omit": 0,
  "duration": 1,
  "bytes": 0,
  "blocks": 0,
  "reverse": 0,
  "tos": 0,
  "target_bitrate": 0,
  "bidir": 0,
  "fqrate": 0,
  "interval": 1
}

@TheRealDJ
Copy link
Contributor Author

@bmah888 Not sure if you saw this one, but it's a small change just to JSON test_start output. If you need me to re-do my branch due to the Merge branch 'esnet:master' into json_add_stat_interval commit, just let me know. My checks were failing until I merged your fqrate changes.

Thanks.
DJ

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Merging shortly.

@bmah888 bmah888 merged commit cd18344 into esnet:master Mar 22, 2024
3 checks passed
swlars pushed a commit that referenced this pull request May 10, 2024
---------------------

* Notable user-visible changes

  * BREAKING CHANGE: iperf3's authentication features, when used with
    OpenSSL prior to 3.2.0, contain a vulnerability to a side-channel
    timing attack. To address this flaw, a change has been made to the
    padding applied to encrypted strings. This change is not backwards
    compatible with older versions of iperf3 (before 3.17). To restore
    the older (vulnerable) behavior, and hence
    backwards-compatibility, use the --use-pkcs1-padding flag. The
    iperf3 team thanks Hubert Kario from RedHat for reporting this
    issue and providing feedback on the fix. (CVE-2024-26306)(PR#1695)

  * iperf3 no longer changes its current working directory in --daemon
    mode. This results in more predictable behavior with relative
    paths, in particular finding key and credential files for
    authentication. (PR#1672)

  * A new --json-stream option has been added to enable a streaming
    output format, consisting of a series of JSON objects (for the
    start of the test, each measurement interval, and the end of the
    test) separated by newlines (#444, #923, #1098).

  * UDP tests now work correctly between different endian hosts
    (#1415).

  * The --fq-rate parameter now works for --reverse tests (#1632, PR#1667).

  * The statistics reporting interval is now available in the --json
    start test object (#1663).

  * A negative time test duration is now properly flagged as an error
    (IS#1662 / PR#1666).

* Notable developer-visible changes

  * Fixes have been made to better (unofficially) support builds on
    Android (#1641 / #1651) and VxWorks (#1595).

  * iperf3 now builds correctly on architectures without native
    support for 64-bit atomic types, by linking with the libatomic
    library (#1611).
swlars pushed a commit that referenced this pull request May 10, 2024
---------------------

* Notable user-visible changes

  * BREAKING CHANGE: iperf3's authentication features, when used with
    OpenSSL prior to 3.2.0, contain a vulnerability to a side-channel
    timing attack. To address this flaw, a change has been made to the
    padding applied to encrypted strings. This change is not backwards
    compatible with older versions of iperf3 (before 3.17). To restore
    the older (vulnerable) behavior, and hence
    backwards-compatibility, use the --use-pkcs1-padding flag. The
    iperf3 team thanks Hubert Kario from RedHat for reporting this
    issue and providing feedback on the fix. (CVE-2024-26306)(PR#1695)

  * iperf3 no longer changes its current working directory in --daemon
    mode. This results in more predictable behavior with relative
    paths, in particular finding key and credential files for
    authentication. (PR#1672)

  * A new --json-stream option has been added to enable a streaming
    output format, consisting of a series of JSON objects (for the
    start of the test, each measurement interval, and the end of the
    test) separated by newlines (#444, #923, #1098).

  * UDP tests now work correctly between different endian hosts
    (#1415).

  * The --fq-rate parameter now works for --reverse tests (#1632, PR#1667).

  * The statistics reporting interval is now available in the --json
    start test object (#1663).

  * A negative time test duration is now properly flagged as an error
    (IS#1662 / PR#1666).

* Notable developer-visible changes

  * Fixes have been made to better (unofficially) support builds on
    Android (#1641 / #1651) and VxWorks (#1595).

  * iperf3 now builds correctly on architectures without native
    support for 64-bit atomic types, by linking with the libatomic
    library (#1611).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants