Freebsd fix #244
Closed
Freebsd fix #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from the field where the kernel leaves it in the tcp_info struct.
for tcp_info usage on another OS.
|
Thanks for the patch! Hoping to get time to look at this soon-ish. Does this pull request replace issue #243? |
|
Yes, it replaces issue #243. |
|
I should perhaps note that I've not actually tested the suggested change on FreeBSD, but I had reason to look at the kernel parts of the TCP_INFO functionality, and spotted the problem when I ported that part to NetBSD, where it's not yet committed but hopefully will be soon. |
|
Superceded by #248. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FreeBSD kernel counts retransmissions in tcpi_snd_rexmitpack.
This changes iperf accordingly, enables retransmissions reporting for FreeBSD,
and uses #elif in a few places to ease the introduction of support for
another OS.