Fixes period.within() to be exclusive of end time #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because that can cause repeats Fixes repeated items in the timeseries alignment when points already fall on boundaries (regression from non-typescript version) Also removes a bunch of unused imports
sartaj10
reviewed
Sep 13, 2018
| @@ -110,7 +108,8 @@ export class Period { | |||
|
|
|||
| /** | |||
| * Returns an `Immutable.List` of `Time`s within the given `TimeRange` | |||
| * that align with this `Period`. | |||
| * that align with this `Period`. Not this will potentially include | |||
There was a problem hiding this comment.
"Now" instead of "Not" ?
Idk if a spelling change is a big thing
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes period.within() to be exclusive of end time. Usually timeranges are defined as >= begin time to <end time, otherwise a to b and b to c includes b twice. But period.within() didn't follow that. This change is in period.ts