This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
output parameters must be ordered as keys #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of
UJObjectUnpackwrites to the output parameters as soon as it finds the corresponding element in theobjObj.In my opinion it should use the order sent by the user in the
_keyNamesargument because, otherwise, the meaning of the output parameters changes when the order of the keys in the JSON input changes. Key order should not alter meaning of JSON objects.I know that this patch alters the meaning of the programs that are already using this function so, if you find it more fair, I can also add a function with a different name.
Thanks!