Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiftkey on iOS is giving problems #385

Open
tvb opened this issue Nov 22, 2014 · 1 comment
Open

Swiftkey on iOS is giving problems #385

tvb opened this issue Nov 22, 2014 · 1 comment
Labels

Comments

@tvb
Copy link
Contributor

tvb commented Nov 22, 2014

I noticed when using Swiftkey on iOS to submit an new post it is not registering the input so the post button stays disabled. Also the @mention system is nog registering input and therefor not suggesting any members but is probably related to the first problem.

@jgknight
Copy link
Contributor

First, can you confirm this is still an issue? We can investigate this however my guess would be that swiftkey isn't triggering a keyup event. You can do this in a browser by pressing down a key in a reply, the buttons won't enable until you let go of the key. This is due to conversation.js

// Add event handlers on the textarea to enable/disable buttons.
        textarea.keyup(function(e) {
                if (e.ctrlKey) return;
                $("#reply .postReply, #reply .saveDraft")[$(this).val() ? "enable" : "disable"]();
                ETConversation.editingReply = $(this).val() ? true : false;
        });

Perhaps we could switch it to .keydown() or .keypress() ? @tvb I don't have an iOS device to test this on with swiftkey. Perhaps if you tried changing this method to one of the other two event handlers and see if that solves the problem?

One issue I potentially see with keydown() is if you hit backspace to clear out a textbox, it may not disable the buttons. Looking at our options, using .change() may actually be best. It watches for value changes. But again I'd need an iOS/Switfkey device to test.

@tobyzerner tobyzerner added the Bug label May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants