Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Firmware support for ESP32-S3-BOX-3 #34

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Nov 10, 2023

Description

  • Add Kconfig to components/box-emu-hal which allows you to select between BOX and BOX 3
  • Refactor components/boxe-emu-hal code to move pin definitions and component selection into box.hpp and box_3.hpp which are selected using the config values in the new hal.hpp that are now used by hal/input, hal/i2s_audio, hal/fs_init, hal/hal_i2c, hal/spi_lcd.

Motivation and Context

Closes #29 with respect to firmware. Additional work is needed to support the new expansion header of the S3-BOX-3 from an electrical / mechanical perspective.

How has this been tested?

  • Building and running on the ESP32-S3-BOX and ESP32-S3-BOX-3
  • Tested touchscreen on both (to make sure x/y config was correct and drivers were working)

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

image
image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Nov 10, 2023
@finger563 finger563 added enhancement New feature or request esp32-s3-box esp32-s3-box-3 hal hardware abstraction layer labels Nov 10, 2023
@finger563 finger563 merged commit 7b478c0 into main Nov 10, 2023
@finger563 finger563 deleted the feature/29-box-3-firmware-support branch November 10, 2023 15:53
@finger563 finger563 mentioned this pull request Dec 17, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request esp32-s3-box esp32-s3-box-3 hal hardware abstraction layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to the new BOX-3
1 participant