fix(cart): made destructor virtual to be overridden by subclasses #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed Cart base class so that destructor is virtual and can be overridden by derived classes and derived destructors will be properly called (so that memory will not be leaked) * Updated how emulators are selected / configured (in cmakelists) and use selected emulator config in cart subclasses for clarity * Updated readme for new roadmap of emulators to port * Removed invalid config settings from sdkconfig.defaults * Added rom info enums for other systems
* Cleaned up gameboy code to make static everything that can be * Cleaned up nes code to move FPS counting to nes.cpp and remove old timeofday based code from the nes implementation so that they are both consistent and measure the same way * Fixed nes code to not re-emulate after loading a save state until the next time the emulation is run. Removes chance of screen showing and decreases load time for it. * Updated sdkconfig defaults to better control memory / allocaiton
finger563
changed the title
…ines and remove the no longer necessary sleeps when changing from lvgl to rom
…d of hardcoded numbers for clarity
* Make transfer callbacks IRAM_ATTR * Make lcd_write function use queued transactions instead of polling transactions so that all lcd comms is using the same mechanisms * Change the max transfer size to be more representative of what is actually being sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
We need to make sure the destructor is called for the carts to ensure the emulation state is properly cleaned up between runs of the emulators.
We also would like an easy way of configuring emulators and such which still shows the carts available and compiles but which doesn't compile in the emulator code (in the case that it's not possible to have all for FLASH / RAM reasons).
How has this been tested?
Building and running on ESP32-S3-BOX
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.