Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/40 brightness controls #41

Merged
merged 12 commits into from
Dec 12, 2023
Merged

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 4, 2023

Description

  • Add brightness controls to gui and menu
  • Update how gpio isr and i2c are initialized to make the ISRs on CPU1 since CPU0 gets full - have to initialize them from within a task
  • Update hal to use and expose new display brightness controls

Motivation and Context

Closes #40
Related ESPP PR: esp-cpp/espp#131

Note: adding the brightness controls (which uses the ESP32 LED controller hardware) required reallocating some of the peripheral interrupts (I2C & GPIO) on Core 1 since Core 0 was filled and could not allocate additional interrupts. Here is the interrupt status for both cores now:

CleanShot 2023-12-04 at 11 32 09

box-emu-fps-brightness-compressed.mp4

How has this been tested?

Building and running on ESP-BOX-EMU

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

display-brightness-compressed.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Add brightness controls to gui and menu
* Update how gpio isr and i2c are initialized to make the ISRs on CPU1 since CPU0 gets full - have to initialize them from within a task
* Update hal to use and expose new display brightness controls
@finger563 finger563 added enhancement New feature or request display brightness labels Dec 4, 2023
@finger563 finger563 self-assigned this Dec 4, 2023
@finger563 finger563 merged commit 9753e80 into main Dec 12, 2023
@finger563 finger563 deleted the feature/40-brightness-controls branch December 12, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant