Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add battery status indication #50

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 28, 2023

Description

  • Update espp submodule to fix bug when unsubscribing from an event
  • Update menu to properly unsubscribe the menu component instead of the gui component (copy paste error from long ago)
  • Add battery header to box-emu-hal which includes the serialization component, adds a battery topic, and adds a BatteryInfo structure (the message data)
  • Updated menu and gui to have battery status icons (battery level symbol, charge symbol) and battery status labels
  • Updated menu and gui to subscribe to the battery topic and update their battery status displays when the event fires
  • Updated main to send new battery info every second to test charge and discharge display in main gui and menu (until hardware V1 arrives with support for actual SoC / charge measurement

Motivation and Context

Closes #24

How has this been tested?

Building and running on V0 Hardware

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

original_da2f502d-6250-4f9b-a8de-5ce91f17ed9f_PXL_20231228_193517933
PXL_20231228_193439991
PXL_20231228_193443114
PXL_20231228_193448240
PXL_20231228_193454054
PXL_20231228_193507217

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update espp submodule to fix bug when unsubscribing from an event
* Update menu to properly unsubscribe the menu component instead of the gui component (copy paste error from long ago)
* Add battery header to box-emu-hal which includes the serialization component, adds a battery topic, and adds a BatteryInfo structure (the message data)
* Updated menu and gui to have battery status icons (battery level symbol, charge symbol) and battery status labels
* Updated menu and gui to subscribe to the battery topic and update their battery status displays when the event fires
* Updated main to send new battery info every second to test charge and discharge display in main gui and menu (until hardware V1 arrives with support for actual SoC / charge measurement
Closes #24
@finger563 finger563 added enhancement New feature or request battery charging indication hal hardware abstraction layer display labels Dec 28, 2023
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 9645f85 into main Dec 28, 2023
2 checks passed
@finger563 finger563 deleted the feature/24-battery-status-ui branch December 28, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
battery charging display enhancement New feature or request hal hardware abstraction layer indication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show battery SoC / status in UI
1 participant