Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sms): fix palette index issue when taking screenshots #53

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

finger563
Copy link
Contributor

Description

Use the palette size when indexing into the palette for taking a screenshot.

Motivation and Context

We'd like the screenshot to exactly reflect the correct state of the game and what is on screen.

Example of how it is now:
image

How has this been tested?

Pausing emulation and looking at the screenshots in both SMS and GG games.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 added bug Something isn't working sms sega master system gg sega game gear labels Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit a18cf2c into main Jan 8, 2024
2 checks passed
@finger563 finger563 deleted the fix/sms-screenshot branch January 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gg sega game gear sms sega master system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant