Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es7210): fix i2c write #54

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix(es7210): fix i2c write #54

merged 1 commit into from
Jan 8, 2024

Conversation

finger563
Copy link
Contributor

Description

  • fix return value of stored i2c_write function in es7210 codec code.

Motivation and Context

Currently the es7210 driver fails to initialize:
CleanShot 2024-01-08 at 10 57 01

How has this been tested?

Building and running on V0 of the hardware.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-01-08 at 10 59 23

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Return proper success value from i2c write funtion to es7210
Copy link

github-actions bot commented Jan 8, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 added bug Something isn't working audio labels Jan 8, 2024
@finger563 finger563 merged commit f494698 into main Jan 8, 2024
2 checks passed
@finger563 finger563 deleted the fix/es7210-write branch January 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant